Spearbit Audit Changes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexonaut
added
Status: Ready for Review
Priority: High
and removed
Priority: Medium
Status: Work In Progress
labels
|
Coverage after merging spearbit-fixes into master will be
Coverage Report
|
|||||||||||||||||||
lucas-manuel
approved these changes
Aug 21, 2024
| if ( | ||
| gracePeriod_ < MINIMUM_GRACE_PERIOD | ||
| ) revert InvalidInitParams(); | ||
|
|
||
| _updateDelay(delay_); |
There was a problem hiding this comment.
Original comment here
| @@ -191,7 +182,7 @@ contract Executor is IExecutor, AccessControl { | |||
| function getCurrentState(uint256 actionsSetId) public view override returns (ActionsSetState) { | |||
| if (actionsSetCount <= actionsSetId) revert InvalidActionsSetId(); | |||
|
|
|||
| ActionsSet storage actionsSet =_actionsSets[actionsSetId]; | |||
| ActionsSet storage actionsSet = _actionsSets[actionsSetId]; | |||
There was a problem hiding this comment.
Original comment here
| @@ -208,7 +199,6 @@ contract Executor is IExecutor, AccessControl { | |||
| uint256 value, | |||
| string memory signature, | |||
| bytes memory data, | |||
| uint256 executionTime, | |||
There was a problem hiding this comment.
Original comment here
|
This PR addresses the following Spearbit issues: https://github.com/spearbit-audits/review-makerdao/issues/11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_executeTransactionIExecutorcomment